Optimize Sorting: shuffle string chars only once per workID #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
- use SliceStable - using a single map for the shuffled string
amirylm
force-pushed
the
AUTO-7299-optimize-sorting-shuffle-string-chars-only-once
branch
from
4d227a1 to
0d1ff28
Compare
ferglor
reviewed
Nov 28, 2023
ferglor
reviewed
Nov 28, 2023
infiloop2
reviewed
Nov 28, 2023
ferglor
approved these changes
Nov 29, 2023
amirylm
deleted the
AUTO-7299-optimize-sorting-shuffle-string-chars-only-once
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-7299
Description
As part of load testing, we found that our sorting doesn’t scale well as it takes too much CPU.
The motivation in this PR is to avoid shuffle the workID string multiple times, by doing it only once.
Changes
AddFromStagingHookis using an additional slice to hold the shuffled strings, and sort that slice instead of the original one that requires to shuffle the workID in each sort operation (up ton^2operations)Testing
There were no new tests added as the current cases cover this change and ensure we didn't break the function