Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto 4599/extended protocol testing #282

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

EasterTheBunny
Copy link
Contributor

@EasterTheBunny EasterTheBunny commented Oct 23, 2023

The intent of this pull request is to merge code related to protocol testing. Included is a collection of functions for modifying outcomes, observations, and reports for testing purposes.

@EasterTheBunny EasterTheBunny force-pushed the AUTO-4599/extended-protocol-testing branch from a8bd733 to 38b74bd Compare October 24, 2023 14:25
@EasterTheBunny EasterTheBunny marked this pull request as ready for review October 24, 2023 14:28
@amirylm
Copy link
Contributor

amirylm commented Oct 30, 2023

Can you add README.md explaining that this package is for testing proposes and to include some short description?

@amirylm
Copy link
Contributor

amirylm commented Oct 30, 2023

Also, we need to make sure we don't run all the normal golang tasks on this package.
Makefile should be updated accordingly, modifying this line should help us avoid it cross tasks

Makefile Show resolved Hide resolved
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EasterTheBunny EasterTheBunny merged commit 7fc76aa into main Oct 31, 2023
@EasterTheBunny EasterTheBunny deleted the AUTO-4599/extended-protocol-testing branch October 31, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants