core/services/ccipcapability: add the ccip capability package #1024
Conversation
* add an implementation for the job delegate * ocr instance launcher and blue/green deployment
makramkd
force-pushed
the
CCIP-2379/ccip-capability-job
branch
from
6e2c9e9 to
26e370d
Compare
| LatestState() (RegistryState, error) | ||
| } | ||
|
|
||
| type ChainConfig interface { |
There was a problem hiding this comment.
This is different on the contract, it includes ChainSelector as well.
| ds sqlutil.DataSource | ||
| peerWrapper *ocrcommon.SingletonPeerWrapper | ||
|
|
||
| isNewlyCreatedJob bool |
There was a problem hiding this comment.
What do you imagine this is going to be used for? It's currently passed into the oracle creator which effectively makes it a constant.
| // blueGreenDeployment represents a blue-green deployment of OCR instances. | ||
| type blueGreenDeployment struct { |
There was a problem hiding this comment.
Where are capabilities actually deployed? Seems weird to have this built into the node.
Currently it seems like this only manages switching between configs. It might be nice to switch between LOOPPs as well.
There was a problem hiding this comment.
Eventually it'll switch between LOOPPs, that LOOPP or not factor is hidden behind the OracleCreator interface.
Capabilities are created on the capability registry, DONs that support a capability are also created there, so the capability registry is the source of truth on that.
| @@ -50,6 +50,7 @@ const ( | |||
| Webhook Type = (Type)(pipeline.WebhookJobType) | |||
| Workflow Type = (Type)(pipeline.WorkflowJobType) | |||
| StandardCapabilities Type = (Type)(pipeline.StandardCapabilitiesJobType) | |||
| CCIP Type = (Type)(pipeline.CCIPJobType) | |||
There was a problem hiding this comment.
It appears that someone was trying to alphabetize these, maybe move this to line 39. Same with the flags below.
| } | ||
|
|
||
| func (d *Delegate) JobType() job.Type { | ||
| return job.CCIP |
There was a problem hiding this comment.
Wondering if the single job for both plugins is going to lead to any kind of limitations.
There was a problem hiding this comment.
We will find out ;-)
|
|
||
| func (d *Delegate) BeforeJobCreated(job.Job) { | ||
| // This is only called first time the job is created | ||
| d.isNewlyCreatedJob = true |
There was a problem hiding this comment.
This seems weird (maybe after it starts being used it becomes clear though): for a newly created delegate newJob = false.
There was a problem hiding this comment.
Yeah this is just standard chainlink job stuff, other jobs do this as well
| } | ||
| } | ||
|
|
||
| func (l *launcher) tick() error { |
There was a problem hiding this comment.
maybe rename tick() to something more meaningful about what happens inside the func
There was a problem hiding this comment.
Can't come up with a good name :-) please suggest
| // 1. Create a new oracle (the green instance) and start it. | ||
| // 2. Shut down the blue instance, making the green instance the new blue instance. | ||
| func (l *launcher) updateDON(don keystone_capability_registry.CapabilityRegistryDONInfo) error { | ||
| if !isMemberOfDON(don, l.p2pID) { |
There was a problem hiding this comment.
Should also check if we are running instances for this DON
Motivation
Solution
Architecture