Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Refactoring #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khezam
Copy link

@khezam khezam commented Feb 8, 2023

The main goal of this PR is to refactor the creation of the Base object in a separate method to avoid duplications.

Let me know what you think as I would love to hear your feedback.

Risk: Low.

@khezam khezam changed the title Remove redundant code Small Refactoring Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 99.30% // Head: 89.00% // Decreases project coverage by -10.31% ⚠️

Coverage data is based on head (cb9354f) compared to base (53831a5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
- Coverage   99.30%   89.00%   -10.31%     
===========================================
  Files           6        6               
  Lines         289      291        +2     
===========================================
- Hits          287      259       -28     
- Misses          2       32       +30     
Impacted Files Coverage Δ
lib/smartcar.rb 78.57% <100.00%> (-21.43%) ⬇️
lib/smartcar/vehicle.rb 77.04% <0.00%> (-22.96%) ⬇️
lib/smartcar/auth_client.rb 94.11% <0.00%> (-3.93%) ⬇️
lib/smartcar_error.rb 93.10% <0.00%> (-3.45%) ⬇️
lib/smartcar/utils.rb 98.43% <0.00%> (-1.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khezam khezam marked this pull request as ready for review February 8, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant