CR changes

smartcar · Jul 11, 2018 · f59e724 · f59e724
1 parent 5a766ae
commit f59e724
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/lib/auth-client.js b/lib/auth-client.js
@@ -67,11 +67,7 @@ function AuthClient(options) {
     development: Joi.boolean(),
   });
 
-  try {
-    Joi.assert(options, schema);
-  } catch (err) {
-    throw err;
-  }
+  Joi.assert(options, schema);
 
   this.clientId = options.clientId;
   this.clientSecret = options.clientSecret;

diff --git a/test/lib/auth-client.js b/test/lib/auth-client.js
@@ -28,13 +28,13 @@ test('constructor', function(t) {
 
 });
 
-test('constructor - validation error', function(t) {
+test('constructor - missing required parameter', function(t) {
 
   t.throws(() => new AuthClient({
     clientId: 'f3266b17-961d-4295-8544-054c7bd94fbb',
     redirectUri: 'https://insurance.co/callback',
     scope: ['read_odometer', 'read_vehicle_info'],
-  }), Error);
+  }));
 
 });
 
@@ -45,7 +45,7 @@ test('constructor - invalid uuid parameter', function(t) {
     clientSecret: CLIENT_SECRET,
     redirectUri: 'https://insurance.co/callback',
     scope: ['read_odometer', 'read_vehicle_info'],
-  }), Error);
+  }));
 
 });
 
@@ -56,7 +56,7 @@ test('constructor - invalid scope parameter', function(t) {
     clientSecret: CLIENT_SECRET,
     redirectUri: 'https://insurance.co/callback',
     scope: 'read_odometer',
-  }), Error);
+  }));
 
 });
 
@@ -68,7 +68,7 @@ test('constructor - invalid development parameter', function(t) {
     redirectUri: 'https://insurance.co/callback',
     scope: ['read_odometer', 'read_vehicle_info'],
     development: 'truthsies',
-  }), Error);
+  }));
 
 });