Skip to content

Commit

Permalink
Merge pull request #151 from smartcar/slim-build-jar
Browse files Browse the repository at this point in the history
feat: prevent all build dependencies from being packaged into a fat jar
  • Loading branch information
s-ashwinkumar authored Aug 6, 2024
2 parents b7ef1ee + 2d5c475 commit 99061b1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 15 deletions.
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,24 @@ The recommended method for obtaining the SDK is via Gradle or Maven through the

### Gradle
```groovy
compile "com.smartcar.sdk:java-sdk:4.5.0"
compile "com.smartcar.sdk:java-sdk:4.5.1"
```

### Maven
```xml
<dependency>
<groupId>com.smartcar.sdk</groupId>
<artifactId>java-sdk</artifactId>
<version>4.5.0</version>
<version>4.5.1</version>
</dependency>
```

### Jar Direct Download
* [java-sdk-4.5.0.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.0/java-sdk-4.5.0.jar)
* [java-sdk-4.5.0-sources.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.0/java-sdk-4.5.0-sources.jar)
* [java-sdk-4.5.0-javadoc.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.0/java-sdk-4.5.0-javadoc.jar)
* [java-sdk-4.5.1.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.1/java-sdk-4.5.1.jar)
* [java-sdk-4.5.1-sources.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.1/java-sdk-4.5.1-sources.jar)
* [java-sdk-4.5.1-javadoc.jar](https://repo1.maven.org/maven2/com/smartcar/sdk/java-sdk/4.5.1/java-sdk-4.5.1-javadoc.jar)

Signatures and other downloads available at [Maven Central](https://central.sonatype.com/artifact/com.smartcar.sdk/java-sdk/4.5.0).
Signatures and other downloads available at [Maven Central](https://central.sonatype.com/artifact/com.smartcar.sdk/java-sdk/4.5.1).

## Usage

Expand Down Expand Up @@ -136,7 +136,7 @@ In accordance with the Semantic Versioning specification, the addition of suppor
[ci-url]: https://travis-ci.com/smartcar/java-sdk
[coverage-image]: https://codecov.io/gh/smartcar/java-sdk/branch/master/graph/badge.svg?token=nZAITx7w3X
[coverage-url]: https://codecov.io/gh/smartcar/java-sdk
[javadoc-image]: https://img.shields.io/badge/javadoc-4.5.0-brightgreen.svg
[javadoc-image]: https://img.shields.io/badge/javadoc-4.5.1-brightgreen.svg
[javadoc-url]: https://smartcar.github.io/java-sdk
[maven-image]: https://img.shields.io/maven-central/v/com.smartcar.sdk/java-sdk.svg?label=Maven%20Central
[maven-url]: https://central.sonatype.com/artifact/com.smartcar.sdk/java-sdk
3 changes: 0 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ jar {
attributes('Implementation-Title': libName,
'Implementation-Version': libVersion)
}
from {
configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) }
}
}

/**
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
libGroup=com.smartcar.sdk
libName=java-sdk
libVersion=4.5.0
libVersion=4.5.1
libDescription=Smartcar Java SDK
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,10 @@ public void testActionStopCharge() throws SmartcarException {
/**
* Test that the vehicle sendDestination action works.
*/
@Test(groups = "vehicle")
public void testActionSendDestination() throws SmartcarException {
this.eVehicle.sendDestination(47.6205063, -122.3518523);
}
// @Test(groups = "vehicle")
// public void testActionSendDestination() throws SmartcarException {
// this.eVehicle.sendDestination(47.6205063, -122.3518523);
// }

/**
* Tests that the batch request method works.
Expand Down

0 comments on commit 99061b1

Please sign in to comment.