Test Coverage #43
Merged
Test Coverage #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: completed call breaker deployment script * feat: added laminator script * feat: deploy script for smarted contract * refactor: formating * feat: added deploy script for SelfCheckout * refactor * fix: format * feat: added crontwoCounter deployment script * refactor: renaming and removing unused variables * feat: added base and sepolia to networks * refactor: removed todo comment
xBalbinus
reviewed
May 27, 2024
| if (owner() != address(0)) { | ||
| revert AlreadyInit(); | ||
| } | ||
| if (_owner == address(0)) { |
There was a problem hiding this comment.
Why are we removing these checks?
There was a problem hiding this comment.
Yes, so there are two reasons here:
- This condition will not occur since we are initialising this through our own Laminator contract
- Even if we do manage to break this, it is initialized using create2 code block which does not revert and emits a
ProxyCreatedevent anyway
There was a problem hiding this comment.
Okay, that's fair, thanks.
xBalbinus
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.