Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bootstrap data secret #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds bootstrap data secret #23

wants to merge 1 commit into from

Conversation

Sadzeih
Copy link

@Sadzeih Sadzeih commented Aug 14, 2020

This PR adds the ability to add a secret to be able to add custom certs or scripts during the bootstrap job.

For example you can add federated roots.

@Sadzeih
Copy link
Author

Sadzeih commented Aug 14, 2020

Ultimately, I think adding a way to add federated roots post-boostrap would be great because currently there's no way to do that.

@dopey dopey requested a review from maraino February 16, 2021 18:31
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sadzeih, thanks for your contribution, I can merge this, but I think the name ca.bootstrap.data is quite confusing, perhaps changing the name to something with the word secret will be more appropriate.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alexis Guerville seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants