Fix RSAPSS salt length check #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the salt length check for RSAPSS. The previous logic was only validating rsa.PSSSaltLengthAuto or the length of the digest, e.g. 32 for SHA256. But rsa.PSSSaltLengthEqualsHash was invalid, and this should be equivalent to the length of the digest. This commit allows using the TLS client handshake with an RSA key because the current logic in Go uses RSAPSS with RSA keys and sets the SaltLenth to rsa.PSSSaltLengthEqualsHash by default. See https://github.com/golang/go/blob/b702e0438ae9577dcc642ba7696a89799c86c8b7/src/crypto/tls/handshake_client_tls13.go#L658-L675
hslatman
approved these changes
Jan 9, 2024
maraino
added a commit
to smallstep/crypto
that referenced
this pull request
Jan 9, 2024
This commit upgrades smallstep/go-attestation to the last commit in the surrogate branch. The new version includes a fix for RSAPSS signing from smallstep/go-attestation#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the salt length check for RSAPSS. The previous logic was only validating
rsa.PSSSaltLengthAutoor the length of the digest, e.g., 32 for SHA256. Butrsa.PSSSaltLengthEqualsHashwas invalid, and this should be equivalent to the length of the digest.This commit allows using the TLS client handshake with an RSA key because the current logic in Go uses RSAPSS with RSA keys and sets the SaltLenth to rsa.PSSSaltLengthEqualsHash by default. See https://github.com/golang/go/blob/b702e0438ae9577dcc642ba7696a89799c86c8b7/src/crypto/tls/handshake_client_tls13.go#L658-L675