Create API tokens with team slug #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
maraino
requested changes
Jul 13, 2023
command/api/token/create.go
Outdated
| @@ -21,7 +21,7 @@ func createCommand() cli.Command { | |||
| Name: "create", | |||
| Action: cli.ActionFunc(createAction), | |||
| Usage: "create a new token", | |||
| UsageText: `**step api token create** <team-id> <crt-file> <key-file> | |||
| UsageText: `**step api token create** <team-id>|<team-slug> <crt-file> <key-file> | |||
There was a problem hiding this comment.
I would use just and use the text in the positional arguments to actually describe what that argument means.
Suggested change
| UsageText: `**step api token create** <team-id>|<team-slug> <crt-file> <key-file> | |
| UsageText: `**step api token create** <team> <crt-file> <key-file> |
command/api/token/create.go
Outdated
| @@ -32,8 +32,8 @@ func createCommand() cli.Command { | |||
|
|
|||
| ## POSITIONAL ARGUMENTS | |||
|
|
|||
| <team-id> | |||
| : UUID of the team the API token will be issued for. This is available in the Smallstep dashboard. | |||
| <team-id>|<team-slug> | |||
There was a problem hiding this comment.
Suggested change
| <team-id>|<team-slug> | |
| <team> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
API auth tokens with team slug
Pain or issue this feature alleviates:
Previous you needed to supply the team UUID to get an auth token for the API.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
In what environments or workflows is this feature supported?
Getting an auth token from the Gateway API.
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!