Add support in for signing and publishing RPM and Deb packages to GCP Artifact Registry #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
tashian
reviewed
Jul 23, 2024
maraino
reviewed
Jul 23, 2024
tashian
reviewed
Jul 23, 2024
tashian
reviewed
Jul 23, 2024
| --package "${PACKAGE}" \ | ||
| --filter "VERSION:${VER}" \ | ||
| --format json 2> /dev/null \ | ||
| | jq -re '.[].name?' >/dev/null 2>&1 \ |
There was a problem hiding this comment.
might need to install jq on the VM
There was a problem hiding this comment.
JQ comes preinstalled on the ubuntu action IIRC.
maraino
reviewed
Jul 24, 2024
| version: 2 | ||
| project_name: step | ||
|
|
||
| variables: | ||
| packageName: step-cli | ||
| packageRelease: 1 # Manually update release: in the nfpm section to match this value if you change this |
There was a problem hiding this comment.
What's the reason for not using "{{ .Var.packageRelease }}" in the nfpm section?
There was a problem hiding this comment.
It will default to -1 and you only need to set that if we need to manually change the release and the nfpm section doesn't support variables.
… Artifact Registry.
Co-authored-by: Carl Tashian <[email protected]>
Co-authored-by: Carl Tashian <[email protected]>
jdoss
force-pushed
the
jdoss/Package_Repos
branch
from
ca2217e
to
54d3e3b
Compare
dopey
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for signing RPM and Deb packages and uploading them to GCP Artifact Registry. It also changes the RPM and Deb file name format to use the ConventionalFileName macro in GoReleaser.