Goreleaser s3 upload not working #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
tashian
approved these changes
Jul 23, 2024
maraino
reviewed
Jul 23, 2024
| ids: | ||
| - s3-versioned | ||
| - s3-unversioned | ||
| bucket: '{{ .Env.AWS_S3_BUCKET }}' | ||
| region: us-east-1 |
There was a problem hiding this comment.
We should use an environment variable for this too.
| - provider: s3 | ||
| disable: '{{ if .Prerelease }}true{{ else }}false{{ end }}' | ||
| ids: | ||
| - s3-unversioned |
There was a problem hiding this comment.
Ok, for now, I think we are building the same binaries twice, we could use name_template in the extra_files to change the name of the s3_versioned files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.