-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire SkipValidation further into SCEP provisioner #1991
Open
mishaslavin
wants to merge
5
commits into
smallstep:master
Choose a base branch
from
mishaslavin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
needs triage
Waiting for discussion / prioritization by team
label
Sep 10, 2024
hslatman
reviewed
Sep 17, 2024
thanks for the review, I have made the requested changes. |
hslatman
reviewed
Sep 24, 2024
hslatman
approved these changes
Sep 24, 2024
@mishaslavin one minor linting issue found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
pass SkipValidation further into the SCEP provisioner
Pain or issue this feature alleviates:
When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
No additional docs
In what environments or workflows is this feature supported?
Primarily for custom integrations which create their own provisioner/authority objects
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!