Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire SkipValidation further into SCEP provisioner #1991

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mishaslavin
Copy link

Name of feature:

pass SkipValidation further into the SCEP provisioner

Pain or issue this feature alleviates:

When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

No additional docs

In what environments or workflows is this feature supported?

Primarily for custom integrations which create their own provisioner/authority objects

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 10, 2024
authority/authority.go Outdated Show resolved Hide resolved
scep/options.go Outdated Show resolved Hide resolved
scep/options.go Outdated Show resolved Hide resolved
@mishaslavin
Copy link
Author

thanks for the review, I have made the requested changes.

@hslatman hslatman added this to the v0.27.5 milestone Sep 24, 2024
@hslatman hslatman self-assigned this Sep 24, 2024
@hslatman
Copy link
Member

@mishaslavin one minor linting issue found

@hslatman hslatman modified the milestones: v0.27.5, v0.27.6 Oct 22, 2024
@hslatman hslatman modified the milestones: v0.28.0, v0.28.1 Oct 30, 2024
@hslatman hslatman modified the milestones: v0.28.1, v0.28.2 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants