Check cnf claim with CSR fingerprint #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
This commit allows tying tokens with the provided CSR or SSH public key. Tokens with a confirmation claim kid (cnf.kid) will validate that the provided fingerprint (kid) matches the CSR or SSH public key. This check will only be present in JWK and X5C provisioners. Fixes #1637
1 task
hslatman
reviewed
Apr 2, 2024
hslatman
reviewed
Jul 24, 2024
| } | ||
| for name, tt := range tests { | ||
| t.Run(name, func(t *testing.T) { | ||
| tc := tt(t) | ||
| ctx := NewContextWithMethod(context.Background(), SignIdentityMethod) | ||
| if opts, err := tc.p.AuthorizeSign(ctx, tc.token); err != nil { | ||
| if assert.NotNil(t, tc.err) { | ||
| if assert.NotNil(t, tc.err, err.Error()) { |
There was a problem hiding this comment.
A bit of a weird test case. The tc.err is the expected error, and an assertion on that is unexpected. It was already there, but I don't think this is the right test logic now.
There was a problem hiding this comment.
It works as expected, showing the err.Error() if the assertion fails, but with ad70982 I've changed this file to use testify's assert and require packages.
maraino
changed the title
hslatman
previously approved these changes
Jul 24, 2024
hslatman
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows tying tokens with the provided CSR or SSH public key. Tokens with a confirmation claim kid (
cnf.kid) will validate that the provided fingerprint (kid) matches the CSR or SSH public key.This check will only be present in JWK and X5C provisioners.
Fixes #1637
Related PRs:
cnfclaim cli#1092