Remove OIDC user regexp check #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the regular expression check on OIDC usernames. Although it is not recommended to use any character in a username, it is possible to create and use them. The tool useradd has the flag --badname and adduser has --allow-badname and --allow-all-names to create new users with any character. Moreover, it is possible to create any username with the rest of provisioners. Fixes #1436
github-actions
bot
added
the
needs triage
tashian
approved these changes
Jul 19, 2023
|
Shouldn't this be behind a start up flag? It seems the check is now completely removed/disabled. |
At this moment, I don't see the point of this check. Something to take into account is that principals != usernames. You can configure SSH login a user with a principal |
hslatman
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the regular expression check on OIDC usernames. Although using any character in a username is not recommended, creating and using them is possible. The tool
useraddhas the flag--badname, andadduserhas--allow-badnameand--allow-all-namesto create new users with any character.Moreover, it is possible to create any username with the rest of provisioners.
Fixes #1436