Skip to content

Commit

Permalink
Merge pull request #16 from nmelo/docs-fix-typos
Browse files Browse the repository at this point in the history
Fix a couple typos in documentation and a formatting issue
  • Loading branch information
dopey authored Dec 20, 2018
2 parents a6c846b + d0c7ccd commit e5dff95
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ then, upon `reload`, the Step CA will read it's new configuration from the same
configuration file.

* Step CA requires the password to decrypt the intermediate certificate, again,
upon `reload`. You can auotmate this in one of two ways:
upon `reload`. You can automate this in one of two ways:

* Use the `--password-file` flag in the original invocation.
* Use the top level `password` attribute in the `ca.json` configuration file.
Expand Down
1 change: 1 addition & 0 deletions docs/common-questions.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ communication for your own internal infrastructure? There are several reasons:
* Public CAs can't handle client certificates (mutual TLS)
* It's much harder (and more expensive) to revoke or roll certificates from public CAs
* It relies on a third party that can subvert your security

More broadly, the answer is that web PKI was designed for the web. A lot of the
web PKI design decisions aren't appropriate for internal systems.

Expand Down
2 changes: 1 addition & 1 deletion docs/recommendations.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ are useless without proper attention to configuration and guidelines.
// - ECDHE key exchange algorithm has perfect forward secrecy
// - ECDSA has smaller keys and better performance (than RSA)
// - CHACHA20 with POLY1305 is the cipher mode used by google.
// - CHACHA20 is more performance than GCM and CBC.
// - CHACHA20's performance is better than GCM and CBC.
// NOTE: The http2 spec requires the "TLS_ECDHE_(RSA|ECDSA)_WITH_AES_128_GCM_SHA256"
// ciphersuite be accepted by the server, therefore it makes our list of
// default ciphersuites until we build the functionality to modify our defaults
Expand Down
2 changes: 1 addition & 1 deletion server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (srv *Server) ListenAndServe() error {
return srv.Serve(ln)
}

// Serve runs Serve or ServetTLS on the underlaying http.Server and listen to
// Serve runs Serve or ServeTLS on the underlying http.Server and listen to
// channels to reload or shutdown the server.
func (srv *Server) Serve(ln net.Listener) error {
var err error
Expand Down

0 comments on commit e5dff95

Please sign in to comment.