Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layout handling #21

Merged
merged 11 commits into from
Apr 26, 2024
Merged

Add Layout handling #21

merged 11 commits into from
Apr 26, 2024

Conversation

rue-a
Copy link
Collaborator

@rue-a rue-a commented Apr 12, 2024

This covers handling of Textract LAYOUT_.* blocks (#20). The tests have not been adjusted yet.

Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid!

mets.xml Outdated Show resolved Hide resolved
textract2page/convert_aws.py Outdated Show resolved Hide resolved
textract2page/convert_aws.py Outdated Show resolved Hide resolved
textract2page/convert_aws.py Outdated Show resolved Hide resolved
Comment on lines +821 to +822
# we cover tables separatly
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that already?

So if AWS comes back with a PAGE → LAYOUT_TABLE → TABLE → ... block structure, do we get a TableRegion, or will it be lost (because the top link is missing)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much, we should test it nevertheless.

@bertsky bertsky linked an issue Apr 12, 2024 that may be closed by this pull request
12 tasks
@bertsky bertsky self-requested a review April 15, 2024 10:41
Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rue-a rue-a closed this Apr 26, 2024
@rue-a rue-a reopened this Apr 26, 2024
@rue-a rue-a merged commit 55fe416 into master Apr 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cover results of LAYOUT features
2 participants