Remove obsolete FunctionCode::Disconnect #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
commented
Aug 28, 2024
| /// the underlying transport, e.g. for disconnecting from an | ||
| /// exclusively used serial port. | ||
| /// | ||
| /// This is an ugly workaround, because `tokio-proto` does not |
|
Anyone? I only did a quick test with a USB serial adapter, basically runing the RTU example code in a loop. Unfortunately, I don't remember the details what didn't work in the past with |
uklotzde
force-pushed
the
disconnect
branch
from
3d37fa3 to
8c18784
Compare
uklotzde
force-pushed
the
disconnect
branch
4 times, most recently
from
7a53b95 to
512f089
Compare
Use AsyncWriteExt::shutdown() to release all resources.
uklotzde
force-pushed
the
disconnect
branch
from
512f089 to
ec5b039
Compare
|
We should probably merge this PR and wait for reports from users that are already using |
flosse
approved these changes
Sep 17, 2024
|
Let's give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AsyncWriteExt::shutdown() to release all resources.