-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Exception
type to public api
#246
feat: add Exception
type to public api
#246
Conversation
c8a51d0
to
eee13e1
Compare
Thanks. All changes look reasonable. Does this PR resolve #169? Would you mind adding a change log entry? We need to bump the version to v0.11.0 even though client-only code is unaffected. Not a big deal. What's the reason for using two different GitHub accounts? I was confused and wondering why GitHub requires approval to run the CI builds again. |
Hi, this resolves only the Server side Exception handling of the #169 . But I think it's the easiest minimal change to keep the current code working without modifying too much, and yet adding simplicity to Exception handling in the Server side. In order to resolve #169, we need to also update the Client trait to better handle return to the user, the correct Exception. I think this will be harder because we need to modify a lot of trait, and some of the logic with the Client handling of errors. I'll add a changelog entry 👍🏻 . Oh sorry for the confusion, this one is my personal account and the other one is my work account. I'll only be using this one in the future, sorry for the unexpected change. |
I can also add tests to be sure that the |
Hello 👋🏻 I've added a change log entry for each of the changes. I've also added integration tests for But I've run into 2 issues:
We'll need to update the tests when the client will handle the |
Oh I forgot to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for your efforts!
Hi,
I've added the
Exception
type to the public API in order to be able to use it in theService
implementation first.I've also modified the examples to show how to return an
Exception
from theService
, it requires to change theService
trait. Thus, if it's too much for this PR, I can split it up and keep this PR very short.This is a duplicate of #218 but the author seems unavailable.