Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.7] Split feature "sync" into "rtu-sync" and "tcp-sync" #106

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

uklotzde
Copy link
Member

@uklotzde uklotzde commented Dec 5, 2021

This is required to avoid an unused tokio-serial dependency that is only needed for "rtu-sync" but not for "rtu" (async).

The README and main page of the documentation lists all the public features, including examples on how to use them selectively.

@uklotzde uklotzde added this to the v0.6.0 milestone Dec 5, 2021
@uklotzde uklotzde requested a review from flosse December 5, 2021 11:29
@uklotzde uklotzde force-pushed the split-sync-feature branch 4 times, most recently from cfdcb00 to c8a8bea Compare December 5, 2021 17:09
@uklotzde uklotzde force-pushed the split-sync-feature branch 3 times, most recently from 6e5b11a to e794797 Compare January 29, 2022 16:19
@uklotzde uklotzde force-pushed the split-sync-feature branch 3 times, most recently from 5abf777 to 6626b1d Compare February 18, 2022 11:46
@uklotzde uklotzde force-pushed the split-sync-feature branch from 6626b1d to 20a74a3 Compare April 30, 2022 08:49
@uklotzde uklotzde changed the title [v0.6] Split feature "sync" into "rtu-sync" and "tcp-sync" [v0.7] Split feature "sync" into "rtu-sync" and "tcp-sync" Jan 30, 2023
@uklotzde uklotzde force-pushed the split-sync-feature branch 2 times, most recently from 0c3493d to c620ddd Compare January 30, 2023 12:28
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@uklotzde uklotzde force-pushed the split-sync-feature branch 3 times, most recently from 3c31d81 to 1ffb91f Compare January 31, 2023 13:21
@uklotzde
Copy link
Member Author

The (currently empty) internal feature "sync" is needed for #130. Other than before it has not effect when used alone.

@uklotzde
Copy link
Member Author

uklotzde commented Feb 5, 2023

In the long term the synchronous wrapper code should be removed and/or extracted into a separate library: #145

@uklotzde uklotzde force-pushed the split-sync-feature branch 2 times, most recently from 64c9077 to a278969 Compare February 13, 2023 13:12
@uklotzde uklotzde marked this pull request as ready for review February 13, 2023 13:13
Split feature "sync" into "rtu-sync" and "tcp-sync". This is required
to avoid an unused tokio-serial dependency that is only needed for
"rtu-sync" but not for "rtu" (async).
@flosse flosse merged commit c4e8fb1 into slowtec:main Feb 13, 2023
@uklotzde uklotzde deleted the split-sync-feature branch February 13, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants