Allow unpermitted tags to be added to messages, threads #63
Conversation
| @@ -4,7 +4,7 @@ class MessagesController < ApplicationController | |||
| def show | |||
| authorize @message | |||
|
|
|||
| @message.update(read: true) | |||
| @message.update(read: true) if @message.read == false | |||
There was a problem hiding this comment.
Ano, OK, tak toto revertujem. S Mirom som dohodnuty, spravil si na to Jira task
| @@ -0,0 +1,8 @@ | |||
| module Common | |||
| class AttachedTagLabelComponent < ViewComponent::Base | |||
There was a problem hiding this comment.
Uz sa nam tu trosku motaju dva nazvy: Tag, Label a este nejaky attachedtag. Asi to zjednotme na nieco. Ja som za tagy.
There was a problem hiding this comment.
Tym, ze je vnutri button (krizik) na zmazanie vazby, tak toto je specificky komponent pre zobrazenie tagov, ktore su naviazane na nejaky objekt (zatial vlakno, sprava, ale je to genericke). Preto Attached... To by som vzhladom na citatelnost nechal
Ten Label mozem dat teoreticky prec.
There was a problem hiding this comment.
Ono potom sa to skor podoba na nejakypolymorphic komponent a tam je konvencia xx<able> cize tu by to bolo nieco ako TaggableTagComponent
There was a problem hiding this comment.
Tak uz len tu sa nezhodujeme. Tych komponentov je tam strasne vela (postupne vznikaju, a asi chcu raz za cas upratat) a vychadza mi, ze musia mat co najdeskriptivnejsie nazvy, najma ak su specializovane, t.j. nevadia mi dlhe nazvy. Pretoze je ine TagComponent tu, a TagComponent vo vybere takych, ktore pridavas, a to je zas iny, ako taky, kde manazujes pristupy pre skupiny. Preto prichadzam s kompromisom DestroyableTagRelationComponent
There was a problem hiding this comment.
Ano tomu rozumiem preto som to nenavrhol nazvat TagComponent. DestroyableTagRelationComponent je moc :D
RemovableTagComponent? Destroy je rails/tech vec, domenovo ten tag davas prec, zmazes, nie "znicis".
No description provided.