Add thread_id to all message API endpoints #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@czepiec this is good point, I don't see a reason why we should omit this. |
jsuchal
approved these changes
Dec 19, 2024
luciajanikova
requested changes
Dec 20, 2024
jsuchal
approved these changes
Dec 20, 2024
luciajanikova
approved these changes
Dec 20, 2024
|
@czepiec diky! |
|
@luciajanikova dajme aj na prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reason why the message
thread_idis in the APImessages/syncbut not inmessages/{id}andmessages/search?This PR consistently adds the
thread_idtomessages/{id}andmessages/search. But it's possible I'm missing something and it's meant to be without it.It's not fully tested yet, so it's a draft.