Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-166 Update content_match? conditions in Automation #526

Merged

Conversation

luciajanikova
Copy link
Member

Ukazalo sa, ze niektore XML, ktore prichadzaju z UPVS maju escapovanu diakritiku, co sposobilo problem pri matchovani obsahu priloh v automation, napr. ked chceme ku kazdej uspesnej registracii certifikatu na UPVS pridat Tag, hlada match na "úspešne spracovaná", pricom XML vyzera takto:

      <ns6:InformationMessage xmlns:ns6="http://schemas.gov.sk/form/G2G.InformationMessage/1.3">
        <ns6:Subject>Spracovanie po&#x17E;iadavky v registri autentifika&#x10D;n&#xFD;ch certifik&#xE1;tov</ns6:Subject>
        <ns6:Text>&#x17D;iados&#x165; o zmenu z&#xE1;pisu autentifika&#x10D;n&#xE9;ho certifik&#xE1;tu v registri autentifika&#x10D;n&#xFD;ch certifik&#xE1;tov bola &#xFA;spe&#x161;ne spracovan&#xE1; 29.11.2024 13:00.</ns6:Text>
      </ns6:InformationMessage>

Upravila som tak, aby sa matchovanie kontrolovalo voci UTF-8 XMLku.

@jsuchal
Copy link
Member

jsuchal commented Dec 11, 2024

Je to ale vždy utf8? Nemôže to byť aj niečo iné?

@luciajanikova
Copy link
Member Author

Neviem o inom pripade

@jsuchal
Copy link
Member

jsuchal commented Dec 11, 2024

Nemá väčší zmysel tieto entity fixnut na vstupe a uložiť do db ako utf8?

@luciajanikova
Copy link
Member Author

Uvazovala som aj nad tym, ale mam vacsi respekt pred celoplosnym upravovanim obsahu objektov spravy ako spravit tuto nejaku zmenu v automation. Radsej by som asi isla postupne, ak to nerobi zatial inde problem, zacala by som takto lokalnym fixom.

@jsuchal
Copy link
Member

jsuchal commented Dec 11, 2024

Fer point, dajme si tam todo a mozeme.

Copy link
Member

@jsuchal jsuchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pridame to todo a mozeme.

@luciajanikova luciajanikova merged commit 240a511 into main Dec 12, 2024
3 checks passed
@luciajanikova luciajanikova deleted the GO-166/update_content_match_conditions_is_automation branch December 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants