GO-164 Do not retry Fs::DownloadSentMessageRelatedMessagesJob if NoRelatedMessagesError #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Dec 3, 2024
| class NoRelatedMessagesError < StandardError | ||
| end | ||
|
|
||
| retry_on NoRelatedMessagesError, attempts: 1 do |_job, _error| |
There was a problem hiding this comment.
Toto znie ako mozno aj ocakavane, zvazme ci nepremenujeme na MissingRelatedMessagesError
jsuchal
approved these changes
Dec 3, 2024
luciajanikova
deleted the
GO-164/do_not_retry_download_job_if_no_messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sice sme spravili upravy v #517, job vyfailuje, ale retryuje sa. To nechceme, ved aj tak sync bezi kazde 2h, zbytocne tam tieto joby netocme dokola. Potrebujeme len, aby takyto job vyfailoval, nech vieme o tom, ze sa nieco deje.