Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank results visualization notifications #512

Merged
merged 7 commits into from
Nov 23, 2024
Merged

Blank results visualization notifications #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83e572c
notifications blank visualization
richardlences Nov 22, 2024
a96585f
undo unwanted changes
richardlences Nov 22, 2024
78402fb
undo other unwanted changes
richardlences Nov 23, 2024
2131ded
undo unwanted changes
richardlences Nov 23, 2024
4e65ed1
Merge branch 'blank_results_visualization_notifications' of https://g…
richardlences Nov 23, 2024
7a25c46
fix yarn.lock end of line
richardlences Nov 23, 2024
66416c3
Minor fixes
jsuchal Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/common/blank_results_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def before_render
tags: "tag-slash",
not_found: "magnifying-glass",
boxes: "inbox-stack",
notifications: "bell-slash"
}

@header = t "blank_results.#{@reason}.header"
Expand Down
4 changes: 4 additions & 0 deletions app/views/notifications/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
<%= render Turbo::NextPageAreaComponent.new(id: @next_cursor, url: scroll_notifications_path(cursor: @next_cursor, format: :turbo_stream)) %>
<% end %>
</ul>

<% if @notifications.empty? %>
<%= render Common::BlankResultsComponent.new(:notifications) %>
<% end %>
</div>
</div>
</div>
5 changes: 4 additions & 1 deletion config/locales/sk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,7 @@ sk:
description: 'Zatiaľ nie sú vytvorené žiadne schránky.'
not_found:
header: "Žiadne správy"
description: "Zvolenému vyhľadávaniu nevyhovuje žiadna správa, skúste vybrať iný štítok alebo zmeniť vyhľadávací výraz."
description: "Zvolenému vyhľadávaniu nevyhovuje žiadna správa, skúste vybrať iný štítok alebo zmeniť vyhľadávací výraz."
notifications:
header: "Žiadne notifikácie"
description: "Nemáte žiadne notifikácie."
Loading