GO-151 Fix datetimes fetched from FS API #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Nov 18, 2024
test/models/fs/message_test.rb
Outdated
| require "active_support/all" | ||
|
|
||
| class Fs::MessageTest < ActiveSupport::TestCase | ||
| test "#create_inbox_messages save datetime attributes with the needed timezone" do |
jsuchal
reviewed
Nov 18, 2024
| @@ -78,7 +78,7 @@ def self.create_inbox_message(raw_message) | |||
| "fs_submission_status": raw_message['submission_status'], | |||
| "fs_message_type": raw_message.dig('message_container', 'message_type'), | |||
| "fs_submission_type_id": raw_message['submission_type_id'], # TODO kde pouzit? asi napr. pri vytvarani nazvu suboru pri exporte | |||
| "fs_submission_created_at": Time.parse(raw_message['submission_created_at']).getlocal, | |||
| "fs_submission_created_at": Time.zone.parse(raw_message['submission_created_at']), | |||
There was a problem hiding this comment.
Tu je podozrivé že inde nemáš zone
jsuchal
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existujucich sprav by som spravila iba cez konzolu, v migracii to zvykne byt problem.