GO-83 Save templates MessageDraft content to HTML visualization in order to be searchable #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Oct 15, 2024
app/models/message_draft.rb
Outdated
| @@ -70,6 +70,7 @@ class MessageDraft < Message | |||
|
|
|||
| def update_content(parameters) | |||
| metadata["data"] = parameters.to_h | |||
| self.html_visualization = format_html_visualization | |||
There was a problem hiding this comment.
Toto mi pride podozrive. preco sa to nedeje v tom build_message_from_template?
There was a problem hiding this comment.
Pravda, nebolo to tuto spravne, presunula som.
jsuchal
reviewed
Oct 15, 2024
luciajanikova
force-pushed
the
GO-83/index_template_message_drafts_content
branch
from
78c940b to
8dfb31c
Compare
jsuchal
reviewed
Oct 16, 2024
| @@ -106,6 +106,10 @@ def build_message_from_template(message) | |||
| filled_content.gsub!(template_item[:placeholder], message.metadata['data'][template_item[:name]].to_s) | |||
| end | |||
|
|
|||
| message.update( | |||
There was a problem hiding this comment.
Na tejto metode sa mi mierne nepozdava, ze build robi vlastne create. Za normalnych okolnosti by to malo byt len vytvorenie do pamate bez ulozenia do db, ale asi tomu nieco brani lebo aj vyssie sa to deje.
jsuchal
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#458