GO-170 Add more error messages to autogram controller to support also Firefox, Safari #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Oct 12, 2023
| @@ -74,7 +74,7 @@ export default class extends Controller { | |||
| }).then(function () { | |||
| resolve(); | |||
| }).catch(function (err) { | |||
| if (err.message === "Failed to fetch") { | |||
| if (["Failed to fetch", "NetworkError when attempting to fetch resource.", "Load failed"].includes(err.message)) { | |||
There was a problem hiding this comment.
Nejaký error code tam nie je, toto mi príde fragilne.
There was a problem hiding this comment.
Skusam odchytit, ale zda sa, ze ani nie, rovno to hodi error.
jsuchal
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otestovane na Chrome, Firefox, Safari, aby aplikacia hodila spravnu error hlasku, ak nie je spusteny autogram.