Merge pull request #508 from slovensko-digital/GO-457/concurrent-draf…

…t-submit Prevent concurrent draft submit
slovensko-digital · Nov 18, 2024 · 5df6caf · 5df6caf
2 parents a777ed4 + 187c410
commit 5df6caf
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/app/jobs/fs/submit_message_draft_job.rb b/app/jobs/fs/submit_message_draft_job.rb
@@ -1,4 +1,14 @@
 class Fs::SubmitMessageDraftJob < ApplicationJob
+  include GoodJob::ActiveJobExtensions::Concurrency
+
+  good_job_control_concurrency_with(
+    # Maximum number of unfinished jobs to allow with the concurrency key
+    # Can be an Integer or Lambda/Proc that is invoked in the context of the job
+    total_limit: 1,
+
+    key: -> { "Fs::SubmitMessageDraftJob-#{arguments.first.try(:id)}" }
+  )
+
   def perform(message_draft, bulk_submit: false, fs_client: FsEnvironment.fs_client)
     raise "Invalid message!" unless message_draft.valid?(:validate_data)
 

diff --git a/app/jobs/govbox/submit_message_draft_job.rb b/app/jobs/govbox/submit_message_draft_job.rb
@@ -5,6 +5,16 @@ class SubmissionError < StandardError
   class TemporarySubmissionError < SubmissionError
   end
 
+  include GoodJob::ActiveJobExtensions::Concurrency
+
+  good_job_control_concurrency_with(
+    # Maximum number of unfinished jobs to allow with the concurrency key
+    # Can be an Integer or Lambda/Proc that is invoked in the context of the job
+    total_limit: 1,
+
+    key: -> { "Govbox::SubmitMessageDraftJob-#{arguments.first.try(:id)}" }
+  )
+
   retry_on TemporarySubmissionError, wait: 2.minutes, attempts: 5
 
   retry_on SubmissionError, attempts: 1 do |_job, _error|