Skip to content

Commit

Permalink
mv eidmsdk secret token from gradle build (#28)
Browse files Browse the repository at this point in the history
* mv eidmsdk secret token from gradle build

* use github token to download eidmsdk pkg

* use personal pat for eidmsdk

* add info about gh pat env to readme
  • Loading branch information
celuchmarek authored Jul 2, 2024
1 parent 130b252 commit 34fc6db
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/android_package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ jobs:
AVM_KEYSTORE_PASSWORD: ${{ secrets.GOOGLE_RELEASE_KEYSTORE_PASSWORD }}
AVM_KEY_ALIAS: ${{ secrets.GOOGLE_RELEASE_KEYSTORE_ALIAS }}
AVM_KEY_PASSWORD: ${{ secrets.GOOGLE_RELEASE_KEY_PASSWORD }}
EIDMSDK_ACCESS_TOKEN: ${{ secrets.GH_PAT }}
working-directory: ./app
run: flutter build appbundle --release

Expand All @@ -77,6 +78,7 @@ jobs:
AVM_KEYSTORE_PASSWORD: ${{ secrets.GOOGLE_RELEASE_KEYSTORE_PASSWORD }}
AVM_KEY_ALIAS: ${{ secrets.GOOGLE_RELEASE_KEYSTORE_ALIAS }}
AVM_KEY_PASSWORD: ${{ secrets.GOOGLE_RELEASE_KEY_PASSWORD }}
EIDMSDK_ACCESS_TOKEN: ${{ secrets.GH_PAT }}
working-directory: ./app
run: flutter build apk --release

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ fvm dart run build_runner build --delete-conflicting-outputs

Build **Android** APK:

eid-mSDK binaries are hosted on GitHub package registry. To access the package during build process environment variable `EIDMSDK_ACCESS_TOKEN` needs to be set to a GitHub Personal Access Token that has permission to read package registry.

```shell
fvm flutter build apk
```
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ allprojects {
url = "https://maven.pkg.github.com/eIDmSDK/eID-mSDK-Android/"
credentials {
username = "eIDmSDK"
password = "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"
password = System.getenv("EIDMSDK_ACCESS_TOKEN")
}
}
}
Expand Down

0 comments on commit 34fc6db

Please sign in to comment.