Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vmull2, ngc xzr sbcs xzrs, sbcs xzrs and cmn #53

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

aqjune
Copy link
Contributor

@aqjune aqjune commented Apr 12, 2024

This adds support for a few arithmetic instructions in AArch64.

The updated uarchs are Neoverse N1 and Cortex A55.

Copy link
Collaborator

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aqjune!

Do you mind updating the A55 model as well?

@hanno-becker hanno-becker added the enhancement New feature or request label Apr 12, 2024
@hanno-becker hanno-becker self-requested a review April 12, 2024 04:48
@hanno-becker
Copy link
Collaborator

For other arithmetic ops - what would be a good step to check these?

I don't follow yet -- can you elaborate?

@aqjune
Copy link
Contributor Author

aqjune commented Apr 12, 2024

I don't follow yet -- can you elaborate?

I was wondering whether the subclass relation between AArch*Instruction and the new instructions could silently add cost models to microarchitectures other than Neoverse N1. I checked that it did not introduce that.

Also this PR is updated to support Cortex A55 now too.

@aqjune
Copy link
Contributor Author

aqjune commented Apr 12, 2024

Oops, the committer and author are different. I will quickly amend it...
-> done.

This adds the cost models of the five instructions for Neoverse N1 and Cortex A55.
Copy link
Collaborator

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks June!

@hanno-becker hanno-becker merged commit 71709da into slothy-optimizer:main Apr 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants