Cortex-M7 Kyber Part 2: NTT functions #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Kyber's NTT functions. The forward NTT switched to the
Arch_Armv7M.BranchLoop
type in order to get rid of the spilling feature, which allowed thevmov
+cmp
loop withoutboundaryReserverdRegs
.Possible improvments:
id
when enforcing abefore
constraint. Could likely be resolved by allowing the constraint to be optional such that in case the instruction with a certainid
can't be found AND we're using splitting heuristic, we continue instead of failiing.Arch_Armv7M.BranchLoop
in the inverse NTT.