Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M7: fix kyber matacc - reserve fpu registers #147

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mkannwischer
Copy link
Collaborator

Before the SLOTHY configuration was missing marking the FPU registers as reserved.
Due to that SLOTHY would pick other registers than the ones on the original code.
If those happen to be callee-save registers and are not saved by the function, it won't work.
This was the case for the Kyber mataccs.

@dop-amin
Copy link
Collaborator

dop-amin commented Jan 6, 2025

LGTM

Before the SLOTHY configuration was missing
marking the FPU registers as reserved.
Due to that SLOTHY would pick other registers
than the ones on the original code.
If those happen to be callee-save registers and
are not saved by the function, it won't work.
This was the case for the Kyber mataccs.
@mkannwischer mkannwischer merged commit 4b22d39 into main Jan 7, 2025
13 checks passed
@mkannwischer mkannwischer deleted the m7-kyber-fix-matacc branch January 7, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants