-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow branch instructions inside loops #139
Conversation
2ee0b74
to
660d78d
Compare
I have implemented (1) and (2) - please have a look. |
Thanks, your changes look fine to me! On the performance: I ran the optimizations on main as well as on this branch multiple times and observed "the usual" deviations, sometimes one result was better, sometimes the other. I'd deem this okay; at least I'm assuming no degradation due to this PR. On the broken tests: I was able to reproduce this, either wrong result data being printed in the end or seemingly endless garbage that gets send over UART. There have been two issues: 1. In I address the two things in 8674344. If you think this should be part of this PR, good, if not, feel free to drop it and we handle it separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-optimize the examples we already have in main.
Rest looks good to me! Thank you!
8674344
to
53ef554
Compare
Re-optimized code is added, tests on this code pass and no more weird output. |
Still to do: