Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armv7-M: Add BranchLoop type #129

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Armv7-M: Add BranchLoop type #129

merged 2 commits into from
Dec 18, 2024

Conversation

mkannwischer
Copy link
Collaborator

No description provided.

@mkannwischer mkannwischer mentioned this pull request Dec 18, 2024
Merged
@mkannwischer mkannwischer force-pushed the armv7m-branch-loop branch 2 times, most recently from 151695e to acb04d1 Compare December 18, 2024 10:15
dop-amin
dop-amin requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dop-amin dop-amin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from the one fix that needs to be done in slothy.py and if you'd like you can accept the comment on the loop class.

slothy/targets/arm_v7m/arch_v7m.py Show resolved Hide resolved
slothy/core/slothy.py Show resolved Hide resolved
@mkannwischer mkannwischer merged commit 0d01c50 into main Dec 18, 2024
13 checks passed
@mkannwischer mkannwischer deleted the armv7m-branch-loop branch December 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dop-amin dop-amin dop-amin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkannwischer @dop-amin