-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avs cvv support #9
base: master
Are you sure you want to change the base?
Avs cvv support #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature should be implemented at the AbstractGateway level so that all gateways can leverage this functionality.
src/Gateways/AbstractGateway.php
Outdated
@@ -625,7 +625,7 @@ protected function submit_request( Requests\RequestInterface $request ) { | |||
* @return bool | |||
*/ | |||
protected function handle_response( Requests\RequestInterface $request, Transaction $response ) { | |||
if ($response->responseCode !== '00' && 'SUCCESS' !== $response->responseCode || $response->responseMessage === 'Partially Approved') { | |||
if ($response->responseCode !== '00' && 'SUCCESS' !== $response->responseMessage || $response->responseMessage === 'Partially Approved') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the comparison of 'SUCCESS'
and $response->responseCode
is what we need for GP API. @apetrovici Are you able to confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slogsdon yes, that is for GP-API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.. reverted the changes for result code
src/Gateways/HeartlandGateway.php
Outdated
'R' => 'Retry - system unable to respond', | ||
'S/U' => 'AVS not supported', | ||
'Z/W' => '9-digit zip code match, address no match', | ||
'X/Y' => '5-digit zip code and address match', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're only going to get one of these result codes at a time, so we would need these three groups to be split into individual items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. updated the conditions
@senthilkumar-muthusamy Also, would you mind moving this PR over to https://github.com/globalpayments/globalpayments-woocommerce? We're in the process of decommissioning this repo. Thanks! |
@slogsdon This PR commits moved to https://github.com/globalpayments/globalpayments-woocommerce repo |
…rce#9 (AVS CVV decline conditions added)
…rce#9 (AVS CVV decline conditions added)
Changes for AVS/CVV based decline option