Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avs cvv support #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

senthilkumar-muthusamy
Copy link

Changes for AVS/CVV based decline option

Copy link
Owner

@slogsdon slogsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature should be implemented at the AbstractGateway level so that all gateways can leverage this functionality.

@@ -625,7 +625,7 @@ protected function submit_request( Requests\RequestInterface $request ) {
* @return bool
*/
protected function handle_response( Requests\RequestInterface $request, Transaction $response ) {
if ($response->responseCode !== '00' && 'SUCCESS' !== $response->responseCode || $response->responseMessage === 'Partially Approved') {
if ($response->responseCode !== '00' && 'SUCCESS' !== $response->responseMessage || $response->responseMessage === 'Partially Approved') {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the comparison of 'SUCCESS' and $response->responseCode is what we need for GP API. @apetrovici Are you able to confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slogsdon yes, that is for GP-API

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.. reverted the changes for result code

'R' => 'Retry - system unable to respond',
'S/U' => 'AVS not supported',
'Z/W' => '9-digit zip code match, address no match',
'X/Y' => '5-digit zip code and address match',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're only going to get one of these result codes at a time, so we would need these three groups to be split into individual items.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. updated the conditions

@slogsdon
Copy link
Owner

@senthilkumar-muthusamy Also, would you mind moving this PR over to https://github.com/globalpayments/globalpayments-woocommerce? We're in the process of decommissioning this repo. Thanks!

@senthilkumar-muthusamy
Copy link
Author

senthilkumar-muthusamy commented May 4, 2021

@senthilkumar-muthusamy Also, would you mind moving this PR over to https://github.com/globalpayments/globalpayments-woocommerce? We're in the process of decommissioning this repo. Thanks!

@slogsdon This PR commits moved to https://github.com/globalpayments/globalpayments-woocommerce repo

senthilkumar-muthusamy added a commit to senthilkumar-muthusamy/globalpayments-woocommerce that referenced this pull request May 12, 2021
senthilkumar-muthusamy added a commit to senthilkumar-muthusamy/globalpayments-woocommerce that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants