TR-92: add 3DS #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slogsdon
reviewed
Mar 30, 2021
| checkVersion, | ||
| initiateAuthentication, | ||
| ChallengeWindowSize, | ||
| } = GlobalPayments.ThreeDSecure; |
There was a problem hiding this comment.
We can't use const/let, async/await, or arrow functions due to older browser incompatibilities (e.g. IE 11).
| // Remove notices from all sources | ||
| $( '.woocommerce-error, .woocommerce-message' ).remove(); | ||
|
|
||
| $form.prepend( '<div class="woocommerce-NoticeGroup woocommerce-NoticeGroup-updateOrderReview woocommerce-error">' + message + '</div>' ); |
There was a problem hiding this comment.
Are there any exposed WooCommerce JS methods for displaying error messages so we don't have to keep this in sync with WC?
Merged
apetrovici
commented
Apr 2, 2021
| if (response.version === "ONE") { | ||
| return [4 /*yield*/, handle3ds1VersionCheck(response, data.challengeWindow)]; | ||
| } | ||
| return [4 /*yield*/, handle3dsVersionCheck(response, data.methodWindow)]; |
apetrovici
commented
Apr 2, 2021
Comment on lines
+1767
to
+1769
| function handle3ds1VersionCheck(data, options) { | ||
| return __awaiter(this, void 0, void 0, function () { | ||
| var response; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.