Implement full-screen property for slint Window item #6931
+43
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to programatically to switch to full-screen mode via a new property in the Windows item. The SLINT_FULLSCREEN environment variable will default set this property to true. However settings this property in the slint code will override the SLINT_FULLSCREEN. Fixes slint-ui#6665
|
|
ogoffart
reviewed
Nov 28, 2024
Comment on lines
+965
to
+967
| fn init(self: Pin<&Self>, _self_rc: &ItemRc) { | ||
| #[cfg(feature = "std")] | ||
| self.full_screen.set(std::env::var("SLINT_FULLSCREEN").is_ok()); |
There was a problem hiding this comment.
IIRC, this is called after all properties have been initialized, so that'd overwrite the property set in the .slint file
(But I might remember wrong)
|
Looks overall good to me. Two comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to programatically to switch to full-screen mode via a new property in the Windows item.
The SLINT_FULLSCREEN environment variable will default set this property to true. However settings this property in the slint code will override the SLINT_FULLSCREEN.
Fixes #6665