WIP: compiler: Add a ListResources option for resource embedding
#6525
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
reviewed
Oct 11, 2024
| @@ -90,7 +90,9 @@ fn embed_images_from_expression( | |||
| let mapped_path = | |||
| urls.get(path).unwrap_or(&Some(path.clone())).clone().unwrap_or(path.clone()); | |||
| *path = mapped_path; | |||
| if embed_files != EmbedResourcesKind::Nothing | |||
| if embed_files == EmbedResourcesKind::ListAllResources { | |||
| global_embedded_resources.borrow_mut().insert(path.clone(), None); | |||
There was a problem hiding this comment.
I think that it might be a lot easier to leave global_embedded_resources as it is (don't insert the Option), but instead:
- Always call
embed_image:let image_ref = embed_image(...); - `if embed_files != ListAllResources { *resource_ref = image_ref; }
No change in data structures needed then.
There was a problem hiding this comment.
True, that is a lot simpler.
On the other hand it reads all the images and stores them into the document's embedded_file_resources, processing them along the way. That seems a tad wasteful with regards to both time and memory.
There was a problem hiding this comment.
No, they're not stored anywhere. They're also not read. That's left to the generators.
... which will list all resources that are not going to get embedded as `None` in the Document's `embedded_file_reosurces`. The idea is to use that field to find all used resources in the live preview so that we know what we can watch.
hunger
force-pushed
the
tobias/push-qlmymzlyuwqv
branch
from
a0dee58
to
0d454bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which will list all resources that are not going to get embedded as
Nonein the Document'sembedded_file_reosurces.The idea is to use that field to find all used resources in the live preview so that we know what we can watch.
This is at this point a demo to show what using the
Document::embedded_file_resourcesfor resource listing in the live preview would entail for the compiler.I'd suggest to rename the field itself to
resourcesand to collect this information even when no embedding is requested (most users won't see it anyway) to not have thisListAllResourcesenum value...