LineEdit: fixes cursor draws out of bounds #6382
Conversation
| } | ||
|
|
||
| min-height: i-text-input.preferred-height; | ||
| min-width: max(50px, i-placeholder.min-width); |
There was a problem hiding this comment.
I'm guessing now, but... was this line removed because the real LineEdit components end up with a bigger minimum anyway?
FloVanGH
force-pushed
the
florian/linedit-cursor-fix
branch
from
2a06e96
to
912687f
Compare
| // min-width < 1px could cause trouble on focus | ||
| min-width: max(1px); |
There was a problem hiding this comment.
Why use max(1px) instead of 1px? Could you also please extend the comment to elaborate on what "trouble on focus" means? How could the min-width become zero?
There was a problem hiding this comment.
This is indeed wierd. I think the focus problem appear if the FocusScope or whatever is being clipped has a size of 0, which shouldn't happen. I haven't tried this change, bur I'm afraid that it does something fishy with the default sizing of the LineEdit
There was a problem hiding this comment.
Why use
max(1px)instead of1px? Could you also please extend the comment to elaborate on what "trouble on focus" means? How could the min-width become zero?
Thanks the max thing was just in my head and should not be there. Is removed.
There was a problem hiding this comment.
This is indeed wierd. I think the focus problem appear if the FocusScope or whatever is being clipped has a size of 0, which shouldn't happen. I haven't tried this change, bur I'm afraid that it does something fishy with the default sizing of the LineEdit
Yeah it is strange. But should we nevertheless merge this, because it fixes a bug? I have tried this pr with the example described in the issue and also with different styles and with different width settings, it looks like it works fine. What do you think @ogoffart ?
There was a problem hiding this comment.
Could you also please extend the comment to elaborate on what "trouble on focus" means? How could the min-width become zero? What caused you to modify this line?
There was a problem hiding this comment.
I have edited the comment. It could be 0 because of how a developer uses it from outside. He can define e.g. the width or min-width of a LineEdit. What also causes the problem. @tronical
Fixes #6243