Skip to content

Commit

Permalink
Compile-time feature no-trace-logging to filter trace logging
Browse files Browse the repository at this point in the history
At the moment, this is an opt-in feature (build with `-F no-trace-logging` to enable). We might decide to filter trace logging from our docker builds after experimenting with this.
  • Loading branch information
AhmedSoliman committed Dec 17, 2024
1 parent 6d4c66b commit 97b6fc7
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions benchmarks/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ publish = false
[features]
default = []
frame-pointer = ["pprof/frame-pointer"]
no-trace-logging = ["tracing/max_level_debug", "tracing/release_max_level_debug"]

[dependencies]
restate-core = { workspace = true }
Expand Down
1 change: 1 addition & 0 deletions cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ build = "build.rs"
[features]
default = ["cloud"]
cloud = []
no-trace-logging = ["tracing/max_level_debug", "tracing/release_max_level_debug"]

[dependencies]
restate-admin-rest-model = { workspace = true }
Expand Down
3 changes: 1 addition & 2 deletions crates/core/src/metadata_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ use restate_types::{flexbuffers_storage_encode_decode, Version, Versioned};
use std::future::Future;
use std::sync::Arc;
use std::time::{Duration, Instant};
use tracing::log::trace;
use tracing::{debug, info};
use tracing::{debug, info, trace};

#[derive(Debug, thiserror::Error)]
pub enum ReadError {
Expand Down
1 change: 1 addition & 0 deletions server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ options_schema = [
memory-loglet = ["restate-node/memory-loglet", "restate-admin/memory-loglet"]
replicated-loglet = ["restate-node/replicated-loglet", "restate-admin/replicated-loglet"]
crate_per_service = ["restate-tracing-instrumentation/service_per_crate"]
no-trace-logging = ["tracing/max_level_debug", "tracing/release_max_level_debug"]

[dependencies]
restate-admin = { workspace = true }
Expand Down
1 change: 1 addition & 0 deletions tools/restatectl/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ replicated-loglet = [
"restate-bifrost/replicated-loglet",
]
memory-loglet = ["restate-types/memory-loglet", "restate-bifrost/memory-loglet", "restate-admin/memory-loglet"]
no-trace-logging = ["tracing/max_level_debug", "tracing/release_max_level_debug"]

[dependencies]
restate-admin = { workspace = true, features = ["clients"] }
Expand Down

0 comments on commit 97b6fc7

Please sign in to comment.