Fix Twig security issue #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odan could you please review this PR and if you agree, publish a new release ? Best, |
odan
reviewed
Sep 25, 2024
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpspec/prophecy-phpunit": "^2.0", | ||
| "phpstan/phpstan": "^1.10.59", | ||
| "phpunit/phpunit": "^9.6 || ^10", |
There was a problem hiding this comment.
Not 100% sure, let me check and I'll update my branch or leave a comment here.
There was a problem hiding this comment.
This change has been reverted, it was due to my tests.
|
Thanks @dfranco for the PR. I can merge it if we keep phpunit/phpunit as it was before. |
Fix Twig security issue (CVE-2024-45411) by upgrading twig/twig dependency.
phpunit/phpunit change has been reverted, this pr is ready to be merged. |
|
Thanks @odan Do you plan to publish a release soon ? I need to publish a security release of some of my projets which use twig-view. Best, |
|
Yes, its planned for today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump twig/twig dependency to version 3.11.1 to address a Twig security issue (CVE-2024-45411).
Issue already fixed, and further details are available at GHSA-6j75-5wfj-gh66
phpunit tests result