Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests.yml add PHP 8.4 #3353

Closed
wants to merge 1 commit into from
Closed

Update tests.yml add PHP 8.4 #3353

wants to merge 1 commit into from

Conversation

joanhey
Copy link

@joanhey joanhey commented Nov 27, 2024

Actually show deprecated warnings with PHP 8.4
Working OK with php-di v7

Released 21 Nov 2024.
https://www.php.net/releases/8.4/en.php

Actually show deprecated warnings with PHP 8.4
@coveralls
Copy link

Coverage Status

coverage: 99.427% (-0.002%) from 99.429%
when pulling 70ee22b on joanhey:patch-1
into d6b8c72 on slimphp:4.x.

@odan
Copy link
Contributor

odan commented Dec 1, 2024

The checks for PHP 8.4 are not passing. See details:

https://github.com/slimphp/Slim/actions/runs/12050752263/job/33747015111?pr=3353

@odan
Copy link
Contributor

odan commented Dec 1, 2024

This has be solved by #3362 Thanks.

@odan odan closed this Dec 1, 2024
@joanhey joanhey deleted the patch-1 branch December 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants