Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #104 Type support for actions-exec-wrapper added #175

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

ThulinaWickramasinghe
Copy link
Collaborator

No description provided.

Copy link
Member

@Akalanka47000 Akalanka47000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add the types field as well to the package.json file of this, it's needed to get this linked. Also the commit prefixes in this org usually follow start case, basically feat should go as Feat though it's fine for this

@ThulinaWickramasinghe
Copy link
Collaborator Author

Looks good, can you add the types field as well to the package.json file of this, it's needed to get this linked. Also the commit prefixes in this org usually follow start case, basically feat should go as Feat though it's fine for this

Sorry for the inconvenience. Added the fix now.

Regarding commit message.
Githhoks haven't been setup in my clone of original repo. Hence my mistake didn't trigger an error. Won't happen again.

@Akalanka47000 Akalanka47000 merged commit 5aaa0aa into main Apr 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants