Merge pull request #143 from sliit-foss/patch/mongoose-filter-query

Patch!: updated parsing of select and include
sliit-foss · Jan 24, 2024 · ecdab62 · ecdab62
2 parents c0a43a7 + f1aaef0
commit ecdab62
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/mongoose-filter-query/src/index.js b/packages/mongoose-filter-query/src/index.js
@@ -31,8 +31,8 @@ const mongooseFilterQuery = (req, res, next) => {
     } else {
       req.query.sort = {};
     }
-    req.query.include = req.query.include?.split(",") ?? [];
-    req.query.select = req.query.select?.split(",")?.join(" ") ?? "";
+    req.query.include = req.query.include?.split(",");
+    req.query.select = req.query.select?.split(",")?.join(" ");
   } catch (e) {
     console.error("[ FilterQuery ] - Failed to parse query", e);
   }

diff --git a/packages/mongoose-filter-query/test/index.test.js b/packages/mongoose-filter-query/test/index.test.js
@@ -46,7 +46,7 @@ describe("test mongoose-filter-query", () => {
     });
     test("undefined", async () => {
       mongooseFilterQuery(req, {}, () => {});
-      expect(req.query.include).toEqual([]);
+      expect(req.query.include).toEqual(undefined);
     });
   });
   describe("select", () => {
@@ -56,7 +56,7 @@ describe("test mongoose-filter-query", () => {
     });
     test("undefined", async () => {
       mongooseFilterQuery(req, {}, () => {});
-      expect(req.query.select).toEqual("");
+      expect(req.query.select).toEqual(undefined);
     });
   });
   test("handle error", async () => {