Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vue commands #7 #48

Merged
merged 7 commits into from
Aug 10, 2024
Merged

Added Vue commands #7 #48

merged 7 commits into from
Aug 10, 2024

Conversation

icy-r
Copy link
Contributor

@icy-r icy-r commented Jun 24, 2024

Added basic VueJs CLI commands to the site. (#7 )

Copy link

@SasinduNanayakkara SasinduNanayakkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SasinduNanayakkara

This comment was marked as duplicate.

src/data/vue.js/tertiary-options.js Outdated Show resolved Hide resolved
src/data/vue.js/primary-options.js Outdated Show resolved Hide resolved
The Vue.js imports in the  file were refactored. Additionally, the  file was deleted as it is no longer needed.
@icy-r icy-r closed this Aug 3, 2024
@icy-r icy-r reopened this Aug 3, 2024
@icy-r
Copy link
Contributor Author

icy-r commented Aug 3, 2024

Deleted unwanted files and codes as mentioned. #48

Refactored the Vue.js imports in the primary-options.js file and removed the tertiary-options.js file as it is no longer needed.
@icy-r
Copy link
Contributor Author

icy-r commented Aug 3, 2024

Shorter function added for code simplification. #48

src/util/Shorter.js Outdated Show resolved Hide resolved
src/util/Shorter.js Outdated Show resolved Hide resolved
src/util/Shorter.js Outdated Show resolved Hide resolved
src/util/Shorter.js Outdated Show resolved Hide resolved
icy-r added 3 commits August 3, 2024 23:59
Refactored the alphabeticalSort function in AlphabeticalSort.js to improve code readability and maintainability.
@icy-r
Copy link
Contributor Author

icy-r commented Aug 3, 2024

Thanks for the comments. I've fixed those errors. If there anything else i should consider refactoring please let me know... @ThulinaWickramasinghe

@ThulinaWickramasinghe
Copy link
Collaborator

Thanks for the comments. I've fixed those errors. If there anything else i should consider refactoring please let me know... @ThulinaWickramasinghe

Wonderful. Everything is perfect right now, but we need one small change.

Can you also rename the file AlphabeticalSort.js to alphabetical-sort.js so that the we can make sure we're following the same file naming guideline everywhere?

FYI, only when naming react components it's necessary to follow Pascal Case. Even the react components' file names can follow any other naming case(mostly pascal or kebab). We prefer kebab case, especially for functions.

@icy-r
Copy link
Contributor Author

icy-r commented Aug 4, 2024

sure.. i just made those changes. thanks!

Copy link
Collaborator

@ThulinaWickramasinghe ThulinaWickramasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @icy-r

@ThulinaWickramasinghe ThulinaWickramasinghe merged commit 6f85079 into sliit-foss:main Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants