-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Vue commands #7 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Vue.js imports in the file were refactored. Additionally, the file was deleted as it is no longer needed.
Deleted unwanted files and codes as mentioned. #48 |
Refactored the Vue.js imports in the primary-options.js file and removed the tertiary-options.js file as it is no longer needed.
Shorter function added for code simplification. #48 |
Refactored the alphabeticalSort function in AlphabeticalSort.js to improve code readability and maintainability.
Thanks for the comments. I've fixed those errors. If there anything else i should consider refactoring please let me know... @ThulinaWickramasinghe |
Wonderful. Everything is perfect right now, but we need one small change. Can you also rename the file AlphabeticalSort.js to alphabetical-sort.js so that the we can make sure we're following the same file naming guideline everywhere? FYI, only when naming react components it's necessary to follow Pascal Case. Even the react components' file names can follow any other naming case(mostly pascal or kebab). We prefer kebab case, especially for functions. |
sure.. i just made those changes. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @icy-r
Added basic VueJs CLI commands to the site. (#7 )