Release v3 #72
Merged
Release v3 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch no longer works because the latest version of `@electron/asar` now skips files with an invalid offset or size.
Previously, the bloat patch would still partially leak actual file contents. This commit fixes that so it only writes nonsense that is useless to an attacker.
The key is unique per asarmor installation and should be the exact same from both the JS and C/C++ side. To prevent user error we should not expose the `key` property to the user in the library API or CLI. Instead, we always use the randomly generated key. If a user wishes to rotate the key, they can do so by manually reinstalling `asarmor` or by deleting the `key.txt` file and regenerating it using a script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major release which removes patches that no longer work and simplifies the encryption process. Going forward, asarmor will focus more on the encryption aspect.