feat(smurf_util.turn_on_fixed_tones) #796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
reviewed
Sep 9, 2024
| feedback[channels] = 0 | ||
|
|
||
| self.set_amplitude_scale_array(band, amp) | ||
| self.set_feedback_enable_array(band, amp) |
There was a problem hiding this comment.
Typo, needs to be feedback not amp in line 3858
msilvafe
reviewed
Sep 9, 2024
| @@ -3844,6 +3844,19 @@ def turn_off_fixed_tones(self,band): | |||
| # set by array, not by channel | |||
| self.set_amplitude_scale_array(band,new_amplitude_scale_array) | |||
|
|
|||
| def turn_on_fixed_tones(self, band, channels, tone_power=None): | |||
There was a problem hiding this comment.
What sets the frequency for these channels?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a function to turn on fixed tones, to facilitate integration into
sodetlib....
Jira Issue
ESCRYODET-
Tests done on this branch
Function interfaces that changed
[Indicate here what is the interface that changed, preferably with a link to the code where the interface is defined]
What was the interface before the change
[Describe here how was the original interface]
What will be the new interface after the change
[Describe here how is the new interface, and what the difference with the original interface]