MNT: make gh actions setup use conda and pip to install packages #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
force-pushed
the
gh_actions_use_conda_and_pip
branch
3 times, most recently
from
1f4d56b to
21241a8
Compare
Before it was using the pip '.txt' package files to install things using conda instead. But this doesn't mimic how users locally install packages with conda+pip, and some packages in coda (ex=p4p) are outdated compared to pip.
nstelter-slac
force-pushed
the
gh_actions_use_conda_and_pip
branch
5 times, most recently
from
9f93470 to
29ce288
Compare
Update docs, conda recipe, and automated tests.
nstelter-slac
force-pushed
the
gh_actions_use_conda_and_pip
branch
from
29ce288 to
f3d815a
Compare
jbellister-slac
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was using the pip '.txt' package files to install packages with conda.
But that doesn't mimic how we instruct users to locally install packages with conda+pip, and causes some issues with packages in coda (ex=p4p) being outdated compared to pip and causing actions setup to fail.
The outdated packages are why this patch is needed to later add tests for most recent python version (can't do now b/c pyqt5 only supports up to 3.10, but pyside6 support will test with python latest)
Also this drops python 3.8 automated tests, and update docs and conda recipe for 3.9+ (min supported python version).