MNT: stop install wrong pyca package through pip, and enabled psp test which uses pyca's psp library #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
changed the title
nstelter-slac
changed the title
nstelter-slac
force-pushed
the
pyca_fix
branch
4 times, most recently
from
1674763 to
bc3550b
Compare
|
"works on my machine", need to figure why failing automation also not sure how much issue it is to revert epicscorelibs in order to have pyca... |
nstelter-slac
force-pushed
the
pyca_fix
branch
2 times, most recently
from
89d0b67 to
44e03c3
Compare
|
this patch is blocked for now, |
|
Do I need to make some updates to |
The correct package is on github: https://github.com/slaclab/pyca and on coda: https://anaconda.org/conda-forge/pyca. Need to switch to using correct package, which will fix 'psp' plugin related tests. (psp is part of pyca) Installing correct library and enabling test fixes issue where a user downloads pydm and runs the tests with pytest cmd directly (instead of run_tests.py), only to see 'no module named psp' failure. This failure seems to suggest to user to 'pip install psp', which is the wrong package and confusing.
nstelter-slac
force-pushed
the
pyca_fix
branch
from
44e03c3 to
c194578
Compare
|
btw @tangkong very recently fixed the pyca builds. It should install via pip from github or from the recently updated conda forge build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can be enabled now that we are using correct pyca package from
conda.
Installing correct library and enabling test fixes issue where a user
downloads pydm and runs the tests with pytest cmd directly (instead of
run_tests.py), only to see 'no module named psp' failure. This failure seems to suggest
to user to 'pip install psp', which is entirely the wrong package and
just leads to further confusion.